nicolabs/nicobot
1
0
Fork 0
mirror of https://github.com/nicolabs/nicobot.git synced 2025-09-07 05:14:01 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

+ increased number of attempts to 5 because it doesn't find a translation too often with only 3

Browse source 
+ fixes #7 : increased logs (not truncating anymore + added full 
translation response + added winner language)
~ translate now returns the full JSON answer rather than only the text
This commit is contained in:
nicobo 2020-05-12 22:06:20 +02:00
parent bfe3cda1e0
commit 1133d6c213
No known key found for this signature in database
GPG key ID: 2581E71C5FA5285F
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
nicobot/transbot.py
View file

@ -63,7 +63,7 @@ class Config:
TODO Find a better way to log requests.Response objects TODO Find a better way to log requests.Response objects
""" """
def _logResponse( r ): def _logResponse( r ):
logging.debug("<<< Response : %s\tbody: %.60s[...]", repr(r), r.content ) logging.debug("<<< Response : %s\tbody: %s", repr(r), r.content )
@ -99,7 +99,7 @@ class TransBot(Bot):
else: else:
self.languages = self.loadLanguages(file=languages_file) self.languages = self.loadLanguages(file=languages_file)
# How many different languages to try to translate to # How many different languages to try to translate to
self.tries = 3 self.tries = 5
# After self.languages has been set, we can iterate over to translate keywords # After self.languages has been set, we can iterate over to translate keywords
kws = self.loadKeywords( keywords=keywords, file=keywords_file, limit=LIMIT_KEYWORDS ) kws = self.loadKeywords( keywords=keywords, file=keywords_file, limit=LIMIT_KEYWORDS )
@ -226,7 +226,7 @@ class TransBot(Bot):
target: Target language short code (e.g. 'en') target: Target language short code (e.g. 'en')
source: Source language short code ; if not given will try to guess source: Source language short code ; if not given will try to guess
Returns the plain translated message or None if no translation could be found. Returns the full JSON translation as per the IBM cloud service or None if no translation could be found.
""" """
# curl -X POST -u "apikey:{apikey}" --header "Content-Type: application/json" --data "{\"text\": [\"Hello, world! \", \"How are you?\"], \"model_id\":\"en-es\"}" "{url}/v3/translate?version=2018-05-01" # curl -X POST -u "apikey:{apikey}" --header "Content-Type: application/json" --data "{\"text\": [\"Hello, world! \", \"How are you?\"], \"model_id\":\"en-es\"}" "{url}/v3/translate?version=2018-05-01"
@ -247,9 +247,7 @@ class TransBot(Bot):
# TODO Log full response when it's usefull (i.e. when a message is going to be answered) # TODO Log full response when it's usefull (i.e. when a message is going to be answered)
_logResponse(r) _logResponse(r)
if r.status_code == requests.codes.ok: if r.status_code == requests.codes.ok:
j = r.json() return r.json()
translation = j['translations']
return translation[0]
# A 404 can happen if there is no translation available # A 404 can happen if there is no translation available
elif r.status_code == requests.codes.not_found: elif r.status_code == requests.codes.not_found:
return None return None
@ -283,8 +281,10 @@ class TransBot(Bot):
for lang in langs: for lang in langs:
# Gets a translation in this random language # Gets a translation in this random language
translation = self.translate( message, target=lang['language'] ) translation = self.translate( message, target=lang['language'] )
if translation: logging.debug("Got translation in '%s' : %s",lang['language'],repr(translation))
translated = translation['translation'].rstrip() if translation and len(translation['translations'])>0:
translated = translation['translations'][0]['translation'].rstrip()
# Note : the detected language is in translation['detected_language']
try: try:
lang_emoji = flag.flag(lang['language']) lang_emoji = flag.flag(lang['language'])
except ValueError: except ValueError: