Tests: Use subprocess.run instead of subprocess.Popen where possible

test/client/02-subscribe-env.py

@@ -27,8 +27,8 @@ def do_test(proto_ver, env):
             ]
 
     payload = "message"
-    publish_packet_s = mosq_test.gen_publish("env/config/file/sub", qos=1, mid=1, payload=payload, proto_ver=proto_ver)
+    publish_packet_s = mosq_test.gen_publish("env/config/file/sub", qos=1, mid=1, payload=payload, proto_ver=proto_ver, retain=True)
-    publish_packet_r = mosq_test.gen_publish("env/config/file/sub", qos=1, mid=2, payload=payload, proto_ver=proto_ver)
+    publish_packet_r = mosq_test.gen_publish("env/config/file/sub", qos=1, mid=2, payload=payload, proto_ver=proto_ver, retain=True)
     puback_packet_s = mosq_test.gen_puback(1, proto_ver=proto_ver)
     puback_packet_r = mosq_test.gen_puback(2, proto_ver=proto_ver)
 
@@ -36,18 +36,12 @@ def do_test(proto_ver, env):
 
     try:
         sock = mosq_test.pub_helper(port=port, proto_ver=proto_ver)
-
-        sub = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env)
-        time.sleep(0.1)
         sock.send(publish_packet_s)
         mosq_test.expect_packet(sock, "puback", puback_packet_s)
-        sub_terminate_rc = 0
+
-        if mosq_test.wait_for_subprocess(sub):
+        sub = subprocess.run(cmd, capture_output=True, text=True, env=env)
-            print("sub not terminated")
+        if payload in sub.stdout:
-            sub_terminate_rc = 1
+            rc = sub.returncode
-        (stdo, stde) = sub.communicate()
-        if stdo.decode('utf-8') == payload + '\n':
-            rc = sub_terminate_rc
         sock.close()
     except mosq_test.TestError:
         pass

test/client/02-subscribe-format.py

@@ -45,28 +45,28 @@ def do_test(format_str, expected_output, proto_ver=4, payload="message"):
     props += mqtt5_props.gen_string_pair_prop(mqtt5_props.USER_PROPERTY, "name3", "value3")
     props += mqtt5_props.gen_string_pair_prop(mqtt5_props.USER_PROPERTY, "name4", "value4")
     if proto_ver == 5:
-        publish_packet = mosq_test.gen_publish("02/sub/format/test", qos=0, payload=payload, properties=props, proto_ver=proto_ver)
+        publish_packet = mosq_test.gen_publish("02/sub/format/test", qos=0, payload=payload, properties=props, proto_ver=proto_ver, retain=True)
     else:
-        publish_packet = mosq_test.gen_publish("02/sub/format/test", qos=0, payload=payload, proto_ver=proto_ver)
+        publish_packet = mosq_test.gen_publish("02/sub/format/test", qos=0, payload=payload, proto_ver=proto_ver, retain=True)
 
     broker = mosq_test.start_broker(filename=os.path.basename(__file__), port=port)
 
     try:
         sock = mosq_test.pub_helper(port=port, proto_ver=proto_ver)
-
-        sub = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env)
-        time.sleep(0.1)
         sock.send(publish_packet)
-        sub_terminate_rc = 0
+
-        if mosq_test.wait_for_subprocess(sub):
+        sub = subprocess.run(cmd, capture_output=True, text=True, env=env)
-            print("sub not terminated")
+        
-            sub_terminate_rc = 1
+        have_match = False
-        (stdo, stde) = sub.communicate()
+        for expected_output in expected_outputs:
-        if stdo.decode('utf-8') == expected_output:
+            if sub.stdout.startswith(expected_output):
-            rc = sub_terminate_rc
+                rc = sub.returncode
-        else:
+                have_match = True
-            print("expected: (%d) %s" % (len(expected_output), expected_output))
+                break
-            print("actual:   (%d) %s"  % (len(stdo.decode('utf-8')), stdo.decode('utf-8')))
+        if have_match == False:
+            print(f"input: {format_str}")
+            print("expected: (%d) %s" % (len(expected_outputs), expected_outputs))
+            print("actual:   (%d) %s"  % (len(sub.stdout), sub.stdout))
         sock.close()
     except mosq_test.TestError:
         pass

test/client/03-publish-env.py

@@ -37,15 +37,10 @@ def do_test(proto_ver, env):
     try:
         sock = mosq_test.sub_helper(port=port, topic="#", qos=1, proto_ver=proto_ver)
 
-        pub = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env)
+        pub = subprocess.run(cmd, capture_output=True, env=env)
-        pub_terminate_rc = 0
-        if mosq_test.wait_for_subprocess(pub):
-            print("pub not terminated")
-            pub_terminate_rc = 1
-        (stdo, stde) = pub.communicate()
 
         mosq_test.expect_packet(sock, "publish", publish_packet)
-        rc = pub_terminate_rc
+        rc = pub.returncode
         sock.close()
     except mosq_test.TestError:
         pass

test/client/03-publish-file.py

@@ -47,14 +47,9 @@ def do_test(proto_ver):
     try:
         sock = mosq_test.sub_helper(port=port, topic="#", qos=0, proto_ver=proto_ver)
 
-        pub = subprocess.Popen(cmd, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, env=env)
+        pub = subprocess.run(cmd, env=env)
-        pub_terminate_rc = 0
-        if mosq_test.wait_for_subprocess(pub):
-            print("pub not terminated")
-            pub_terminate_rc = 1
-
         mosq_test.expect_packet(sock, "publish", publish_packet)
-        rc = pub_terminate_rc
+        rc = pub.returncode
         sock.close()
     except mosq_test.TestError:
         pass
@@ -74,4 +69,4 @@ def do_test(proto_ver):
 
 do_test(proto_ver=3)
 do_test(proto_ver=4)
-do_test(proto_ver=5)
+do_test(proto_ver=5)