[FIXED HUDSON-3586] add autocomplete="off" for LDAP managerDN and managerPassword fields,

to avoid unintended data being saved there.
Convert f:password to use MorphTagLibrary (like f:textbox does) so it can accept
arbitrary fields, like autocomplete.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31540 71c3de6d-444a-0410-be80-ed276b4c234a

Originally-Committed-As: d63f4ecb05208b307f351946cd1c118655059667
This commit is contained in:
mindless 2010-05-30 01:11:24 +00:00
parent 6e7d0c9939
commit 8a4337c1bb

View file

@ -1,7 +1,7 @@
<!--
The MIT License
Copyright (c) 2004-2009, Sun Microsystems, Inc., Kohsuke Kawaguchi
Copyright (c) 2004-2010, Sun Microsystems, Inc., Kohsuke Kawaguchi
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
@ -41,12 +41,12 @@ THE SOFTWARE.
<f:textbox name="ldap.groupSearchBase" value="${instance.groupSearchBase}" />
</f:entry>
<f:entry title="${%Manager DN}" help="/help/security/ldap/managerDN.html">
<f:textbox name="ldap.managerDN" value="${instance.managerDN}"
<f:textbox name="ldap.managerDN" value="${instance.managerDN}" autocomplete="off"
checkUrl="'${rootURL}/securityRealms/LDAPSecurityRealm/serverCheck?field=managerDN&amp;server='+encodeURIComponent(this.form.elements['ldap.server'].value)+'&amp;managerDN='+encodeURIComponent(this.value)+'&amp;managerPassword='+encodeURIComponent(this.form.elements['ldap.managerPassword'].value)"
/>
</f:entry>
<f:entry title="${%Manager Password}" help="/help/security/ldap/managerPassword.html">
<f:password name="ldap.managerPassword" value="${instance.managerPassword}"
<f:password name="ldap.managerPassword" value="${instance.managerPassword}" autocomplete="off"
checkUrl="'${rootURL}/securityRealms/LDAPSecurityRealm/serverCheck?field=password&amp;server='+encodeURIComponent(this.form.elements['ldap.server'].value)+'&amp;managerDN='+encodeURIComponent(this.form.elements['ldap.managerDN'].value)+'&amp;managerPassword='+encodeURIComponent(this.value)"
/>
</f:entry>