nicolabs/Android-Password-Store
1
0
Fork 0
mirror of https://github.com/android-password-store/Android-Password-Store.git synced 2025-09-06 04:51:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

PasswordEntry: add more potential fields for username (#764)

Browse source
This commit is contained in:
Harsh Shandilya 2020-05-06 01:58:05 +05:30 committed by GitHub
parent f99a14d95b
commit feab56994d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/src/androidTest/java/com/zeapo/pwdstore/PasswordEntryTest.kt
View file

@ -34,6 +34,10 @@ class PasswordEntryTest {
} }
@Test fun testGetUsername() { @Test fun testGetUsername() {
for (field in PasswordEntry.USERNAME_FIELDS) {
assertEquals("username", PasswordEntry("\n$field username").username)
assertEquals("username", PasswordEntry("\n${field.toUpperCase()} username").username)
}
assertEquals( assertEquals(
"username", "username",
PasswordEntry("secret\nextra\nlogin: username\ncontent\n").username) PasswordEntry("secret\nextra\nlogin: username\ncontent\n").username)
@ -42,6 +46,9 @@ class PasswordEntryTest {
PasswordEntry("\nextra\nusername: username\ncontent\n").username) PasswordEntry("\nextra\nusername: username\ncontent\n").username)
assertEquals( assertEquals(
"username", PasswordEntry("\nUSERNaMe: username\ncontent\n").username) "username", PasswordEntry("\nUSERNaMe: username\ncontent\n").username)
assertEquals("username", PasswordEntry("\nlogin: username").username)
assertEquals("foo@example.com", PasswordEntry("\nemail: foo@example.com").username)
assertEquals("username", PasswordEntry("\nidentity: username\nlogin: another_username").username)
assertEquals("username", PasswordEntry("\nLOGiN:username").username) assertEquals("username", PasswordEntry("\nLOGiN:username").username)
assertNull(PasswordEntry("secret\nextra\ncontent\n").username) assertNull(PasswordEntry("secret\nextra\ncontent\n").username)
} }

15
app/src/main/java/com/zeapo/pwdstore/PasswordEntry.kt
View file

@ -5,6 +5,8 @@
package com.zeapo.pwdstore package com.zeapo.pwdstore
import android.net.Uri import android.net.Uri
import androidx.annotation.VisibleForTesting
import androidx.annotation.VisibleForTesting.PRIVATE
import java.io.ByteArrayOutputStream import java.io.ByteArrayOutputStream
import java.io.UnsupportedEncodingException import java.io.UnsupportedEncodingException
@ -162,7 +164,16 @@ class PasswordEntry(private val content: String) {
} }
companion object { companion object {
@VisibleForTesting(otherwise = PRIVATE)
private val USERNAME_FIELDS = arrayOf("login:", "username:") val USERNAME_FIELDS = arrayOf(
"login:",
"username:",
"account:",
"email:",
"name:",
"handle:",
"id:",
"identity:"
)
} }
} }