nicolabs/Android-Password-Store
1
0
Fork 0
mirror of https://github.com/android-password-store/Android-Password-Store.git synced 2026-02-22 18:31:50 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Autofill regression caused by empty dataset (#1184)

Browse source
This commit is contained in:
Fabian Henneke 2020-11-03 17:40:31 +01:00 committed by Harsh Shandilya
parent 0e9843ccba
commit 82dd9e2b73
No known key found for this signature in database
GPG key ID: 366D7BBAD1031E80
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/com/zeapo/pwdstore/autofill/oreo/AutofillResponseBuilder.kt
View file

@ -53,14 +53,14 @@ class AutofillResponseBuilder(form: FillableForm) {
}
private fun makeMatchDataset(context: Context, file: File): Dataset? {
if (scenario.hasFieldsToFillOn(AutofillAction.Match)) return null
if (!scenario.hasFieldsToFillOn(AutofillAction.Match)) return null
val remoteView = makeFillMatchRemoteView(context, file, formOrigin)
val intentSender = AutofillDecryptActivity.makeDecryptFileIntentSender(file, context)
return makePlaceholderDataset(remoteView, intentSender, AutofillAction.Match)
}
private fun makeSearchDataset(context: Context): Dataset? {
if (scenario.hasFieldsToFillOn(AutofillAction.Search)) return null
if (!scenario.hasFieldsToFillOn(AutofillAction.Search)) return null
val remoteView = makeSearchAndFillRemoteView(context, formOrigin)
val intentSender =
AutofillFilterView.makeMatchAndDecryptFileIntentSender(context, formOrigin)
@ -68,14 +68,14 @@ class AutofillResponseBuilder(form: FillableForm) {
}
private fun makeGenerateDataset(context: Context): Dataset? {
if (scenario.hasFieldsToFillOn(AutofillAction.Generate)) return null
if (!scenario.hasFieldsToFillOn(AutofillAction.Generate)) return null
val remoteView = makeGenerateAndFillRemoteView(context, formOrigin)
val intentSender = AutofillSaveActivity.makeSaveIntentSender(context, null, formOrigin)
return makePlaceholderDataset(remoteView, intentSender, AutofillAction.Generate)
}
private fun makeFillOtpFromSmsDataset(context: Context): Dataset? {
if (scenario.hasFieldsToFillOn(AutofillAction.FillOtpFromSms)) return null
if (!scenario.hasFieldsToFillOn(AutofillAction.FillOtpFromSms)) return null
if (!AutofillSmsActivity.shouldOfferFillFromSms(context)) return null
val remoteView = makeFillOtpFromSmsRemoteView(context, formOrigin)
val intentSender = AutofillSmsActivity.makeFillOtpFromSmsIntentSender(context)